Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement RoleFlags #2487

Merged
merged 15 commits into from
Jul 1, 2024
Merged

feat: implement RoleFlags #2487

merged 15 commits into from
Jul 1, 2024

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Jun 30, 2024 •
edited
Loading

Summary

Adds RoleFlags as per discord/discord-api-docs#6269
(Side note: really?)

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner June 30, 2024 19:48
@pullapprove4 pullapprove4 bot requested a review from VincentRPS June 30, 2024 19:48
plun1331
plun1331 requested changes Jun 30, 2024
View reviewed changes
discord/flags.py Outdated Show resolved Hide resolved
@plun1331
Update discord/flags.py
359a7ef 
Signed-off-by: plun1331 <plun1331@gmail.com>
plun1331
plun1331 previously requested changes Jun 30, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs formatting is screwed up

Dorukyum
Dorukyum requested changes Jun 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
NeloBlivion and others added 3 commits June 30, 2024 22:06
@NeloBlivion @Dorukyum
Update CHANGELOG.md
f0cfb8e 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
@NeloBlivion
fix docs
8f124d7
@NeloBlivion
again?
da1d232
@Dorukyum Dorukyum changed the title feat: Implement RoleFlags feat: implement RoleFlags Jun 30, 2024
@NeloBlivion
better formatting
c1417ee
@NeloBlivion
Merge branch 'master' into roleflags
e638b0e 
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Dorukyum
Dorukyum reviewed Jun 30, 2024
View reviewed changes
discord/flags.py Outdated Show resolved Hide resolved
@Dorukyum
flags.py aktualisieren
7302062 
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
Dorukyum previously approved these changes Jun 30, 2024
View reviewed changes
@Dorukyum Dorukyum enabled auto-merge (squash) June 30, 2024 23:20
Lulalaby
Lulalaby previously approved these changes Jul 1, 2024
View reviewed changes
@Lulalaby Lulalaby disabled auto-merge July 1, 2024 00:59
@Lulalaby
Copy link
Member

Lulalaby commented Jul 1, 2024

conflicts

plun1331
plun1331 reviewed Jul 1, 2024
View reviewed changes
discord/flags.py Outdated Show resolved Hide resolved
@NeloBlivion NeloBlivion dismissed stale reviews from Lulalaby and Dorukyum via 083e71f July 1, 2024 01:41
@NeloBlivion
resolve conflicts
ef0e931
@NeloBlivion
Merge branch 'master' into roleflags
2d054d5 
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
@NeloBlivion
revert
0c196d6
@Dorukyum Dorukyum enabled auto-merge (squash) July 1, 2024 10:55
@Lulalaby Lulalaby disabled auto-merge July 1, 2024 11:31
@Lulalaby Lulalaby merged commit af87860 into Pycord-Development:master Jul 1, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 left review comments

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NeloBlivion @Lulalaby @plun1331 @Dorukyum